search

openSUSE / combustion

Configure MicroOS on the first boot
GNU General Public License v2.0
14 stars 7 forks source link

improve check for qemu_fw_cfg config #17

Closed fcrozat closed 3 months ago

fcrozat commented 4 months ago

check for qemu_fw_cfg/by_name/opt/org.opensuse.combustion/script existence before trying to copy it

if another name is used, it should be ignored without breaking ignition.

Vogtinator commented 4 months ago

if another name is used, it should be ignored without breaking ignition.

Ignition uses com.coreos.ignition

fcrozat commented 4 months ago

I don't understand the purpose of this change. There is already a check for /opt/org.opensuse.combustion above .

Yes, sorry, it is missing a more verbose explanation. I was doing some tests and wanted to comment the combustion script, so I renamed the fwcfg configuration to opt/org.opensuse.combustion/fobar-script, so it would be ignored. But it causes an error in combustion.

Doing a similar rename with ignition worked nicely, ignition didn't had a error

Vogtinator commented 4 months ago

If combustion finds that there's a disk folder combustion or a fwcfg folder org.opensuse.combustion, it assumes that running combustion is wanted and if there is no script it's treated as a fatal error. That's intentional.

For testing without combustion I just rename it to org.nopensuse.combustion/script here.

Vogtinator commented 3 months ago

Closing as intentional - please reopen if you disagree.