search

openSUSE / cpanspec

Create openSUSE spec files form cpan tar files
Other
8 stars 10 forks source link

Use %license #11

Closed jayvdb closed 5 years ago

jayvdb commented 5 years ago

I believe the generated spec's should use %license , similar to how https://github.com/openSUSE/py2pack/ works.

coolo commented 5 years ago

It does. It depends on the detection of license filenames though. But look e.g. at https://build.opensuse.org/package/view_file/openSUSE:Factory/perl-Test-Inter/perl-Test-Inter.spec?expand=1

If it doesn't work on an example then because this function failed: https://github.com/openSUSE/cpanspec/blob/master/cpanspec#L724

jayvdb commented 5 years ago

ok, ill retrace my steps to see which cases I encountered where it wasnt working.

As an aside, other differences with py2pack / spec-cleaner i've noticed

jayvdb commented 5 years ago

%license didnt work on https://build.opensuse.org/package/show/home:jayvdb:branches:devel:languages:perl/perl-Dist-Zilla-Plugin-Git

coolo commented 5 years ago

BuildRoot is not necessary, no. And about URL vs Url exists a long discussion on opensuse-packaging - it's a matter of taste.

coolo commented 5 years ago

Well, https://grammarist.com/spelling/licence-license/ :)

But that should be a quick fix

jayvdb commented 5 years ago

Fixed in https://github.com/openSUSE/cpanspec/commit/43afd0f463eb5c7375f948c6a99afe9ac086bb0d