search

openSUSE / docmanager

Manage DocBook 5 Meta Information
http://opensuse.github.io/docmanager/index.html
GNU General Public License v3.0
6 stars 6 forks source link

Remove Action class #34

Closed tomschr closed 9 years ago

tomschr commented 9 years ago

The Action class from action.py is useless as it doesn't really improve code quality. One (better?) implementation avoids this class and uses just a function, see the feature/issue23 branch.

mschnitzer commented 9 years ago

I would say this can be seen as a part of our planned "refactoring-update" after 3.0 has been released, right? I don't think milestone 3.0 is a good choice for that.

@tomschr What do you mean?

tomschr commented 9 years ago

Yes, as this is no blocker bug, I'd say this can be done for the 3.1 milestone.

mschnitzer commented 9 years ago

As we discussed it again, we came to the solution that we don't want to remove the "Actions" class. What we removed is the "Files" class in filehandler.py. This is done in https://github.com/openSUSE/docmanager/commit/6b80961c1fea2645d9558102709e6267ead61a16