add configurations for Noto Sans/Serif CJK

openSUSE / fonts-config

7 stars 13 forks source link

add configurations for Noto Sans/Serif CJK #2

Closed marguerite closed 6 years ago

marguerite commented 6 years ago

@ftake please help reviewing this

ftake commented 6 years ago

too many things are mixed in one commit. so difficult to review.

ftake commented 6 years ago

Added small comments. I need time to test the change.

marguerite commented 6 years ago

@ftake

Good point! Maybe I we open Noto Sans and Adobe Source Sans Pro with fontforge to see the details, and then decide to override or not.

And, I am also curious if my substitutions still works when a user does have Noto Sans CJK SC installed from elsewhere .

ftake commented 6 years ago

How about fixing one by one with simple changes and from important things? We have only a little time until Leap 15.0.

Some OSS applications expect Noto Sans CJK JP/KR/SC/TC. So we should provide alias between Noto Sans CJK JP/KR/SC/TC and Noto Sans JP/KR/SC/TC.
We have to update virtual fonts: sans-serif, serif, monospace

marguerite commented 6 years ago

@ftake sure.

I tested Noto Sans and Adobe Source Sans Pro. the later is smaller than Noto Sans.

basically, Noto Sans 12 = Adobe Source Sans Pro 14.

I agree we should leave this substitution to further releases, and focus on the most important things.

ftake commented 6 years ago

Thanks.

BTW, this comment is not directly related to this topic but basically, you should not commit unrelated changes together for example, 99-example.conf and TODO. If you want to add it, you have to make a new commit.

marguerite commented 6 years ago

99-example.conf was empty.conf which was not imported in the initial commit...anyway I'll keep an eye on it.

BTW, @ftake, I think you should ask our infrastructure man to add you to M17N group in github. then you have manage access to this repo. I am not able to let you in :-(