search

openSUSE / get-o-o

Website that provides detailed information about openSUSE distributions
https://get.opensuse.org
Creative Commons Attribution Share Alike 4.0 International
60 stars 46 forks source link

Add signature download, fix verification description (boo#1211156). #197

Closed hramrach closed 5 months ago

tacerus commented 5 months ago

Adding all these quotes is unnecessary and not related to the described issue.

hramrach commented 5 months ago

They are not causing problem, are they?

It's not like I would add this by hand, and the yaml generator considers the URLs too complex to leave them unquoted.

tacerus commented 5 months ago

They are not, but neither are the strings causing a problem for the YAML parsing unless YAML control characters standing alone are part of the strings, which does not seem to be the case. I suggest to propose different YAML formatting as a separate patch.

hramrach commented 5 months ago

The different yaml formatting is a result of roundtrip through yaml parser/serializer adding the extra lines programatically in-between. It's not intentional change but so long as the result is usable I see no problem with it.

hellcp commented 5 months ago

It makes reviewing actual intended changes difficult, so I disagree it makes no difference

hramrach commented 5 months ago

The formatting change is now in a separate patch

hramrach commented 5 months ago

Looks good, thanks.