search

openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

gitarro does not mark tests as failed at GitHub if it's not able to clone a forked private repository #113

Closed juliogonzalez closed 6 years ago

juliogonzalez commented 6 years ago

https://ci.suse.de/job/manager-prs-schema-migration-pipeline/3947/console

It failed the test at Jenkins (OK), but the PR was not updated: https://github.com/SUSE/spacewalk/pull/2665#pullrequestreview-78753789

MalloZup commented 6 years ago

closing because this was an issue specific to github user credentials:

https://github.com/SUSE/spacewalk/pull/3225

juliogonzalez commented 6 years ago

Reopening, because there is a bug yet.

If the clone fails, the test must be marked as failed at GitHub, and right now it stays "running forever".

It could be seen at https://github.com/SUSE/spacewalk/pull/3225, the Jenkins job was marked as failed, but the test was still 'yellow' and running at the GiHub status for the PR.

juliogonzalez commented 6 years ago

Hapenning again at https://ci.suse.de/job/manager-tests-pipe/26790/console

MalloZup commented 6 years ago

@juliogonzalez do we fixed this or not? with the latest PR?

juliogonzalez commented 6 years ago

@MalloZup I am not sure.

I would say yes, but I'd need to test it. For that I need a special cloned private repository with the inherited permissions removed it, so let's keep it for a while, until I can verify it.

MalloZup commented 6 years ago

@juliogonzalez ok thx ! :boat:

MalloZup commented 6 years ago

@juliogonzalez i am optimistic so i close this, and feel free to reopen in case opposite