search

openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

Simplyfiy each with enum of ruby #143

Closed MalloZup closed 6 years ago

MalloZup commented 6 years ago

here https://github.com/openSUSE/gitarro/blob/master/lib/gitarro/backend.rb#L123

we can use on of the https://ruby-doc.org/core-2.5.1/Enumerable.html for avodind the push inside each. ( i think collect is the right one to use)

ozmar-11 commented 6 years ago

I would like to take this one

MalloZup commented 6 years ago

@ozmar-11 feel free to improve the code ! :+1:

ozmar-11 commented 6 years ago

@MalloZup could you please review my PR?

MalloZup commented 6 years ago

@ozmar-11 done thank you!

ozmar-11 commented 6 years ago

Great, thanks

MalloZup commented 6 years ago

@ozmar-11 have nice day! ciao thank you