openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

[6346] Allow skipping changelog test from description #154

Closed srbarrios closed 5 years ago

srbarrios commented 5 years ago

What does this PR do?

Related to Task: https://github.com/SUSE/spacewalk/issues/6346

It changes the way we re-run tests and we specify if changelog must be checked. we will use the checkboxes you see bellow:

In the first case, gitarro will change from checked to unchecked after re-run th test.

srbarrios commented 5 years ago

Cool! Thank you @MalloZup !

MalloZup commented 5 years ago

@srbarrios other then adressing the comments, take a look at travis and make rubocop happy.

https://travis-ci.org/openSUSE/gitarro/builds/474335708?utm_source=github_status&utm_medium=notification :sunflower:

Some things are unrelated to your PR but some not

MalloZup commented 5 years ago

@srbarrios the checkbox idea in highlevel perspective is a clever one idea. ( allthough the comment trigger should stay)

For the acceptance test needed by this feature, take a look at this doc:

https://github.com/openSUSE/gitarro/blob/master/doc/TESTS.md#acceptance-tests

srbarrios commented 5 years ago

@srbarrios the checkbox idea in highlevel perspective is a clever one idea. ( allthough the comment trigger should stay)

For the acceptance test needed by this feature, take a look at this doc:

https://github.com/openSUSE/gitarro/blob/master/doc/TESTS.md#acceptance-tests

It should be fine now, all the tests are passing, rubocop is green and I changed the doc. Take a look please

MalloZup commented 5 years ago

thx @srbarrios i will have look tmw :rocket:

MalloZup commented 5 years ago

@srbarrios please rebase the commits

MalloZup commented 5 years ago

@juliogonzalez i let you release the rubygem and update the stuff on manager side

srbarrios commented 5 years ago

holding to red , i will make it green once rebased.

Yep, Im on it, I had a conflict with CHANGELOG.md after rebase and is why you see more commits, trying to see how to fix it.

srbarrios commented 5 years ago

Ok, I can't, I think I'm forced to have two commits :/ As CHANGELOG was a new file added on master.

MalloZup commented 5 years ago

ok for 2 commits no pb but you should rebase to upstream/master for avoding the merge commit

srbarrios commented 5 years ago

ok for 2 commits no pb but you should rebase to upstream/master for avoding the merge commit

Yep, is what I did. But after rebase upstream/master, I though I would be able to rebase all in one commit, but doing it it show me the conflict with CHANGELOG.md, so I guess I will need to keep it in a separate commit

MalloZup commented 5 years ago

ok for 2 commits no pb but you should rebase to upstream/master for avoding the merge commit

Yep, is what I did. But after rebase upstream/master, I though I would be able to rebase all in one commit, but doing it it show me the conflict with CHANGELOG.md, so I guess I will need to keep it in a separate commit

try harder, resolve the conflict again and you will fix it. This is a common annoying issue on git but you can still fix it.

basically you need to find out with git rebase --continue or --skip and you will have it