search

openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

check status of testacc #164

Closed MalloZup closed 4 years ago

MalloZup commented 5 years ago

tasks:

we might need to check if the testacc are failing for PRs or need some improvements for catching errors.

The root cause was a PR where tests were ok but we didn't catch a regression

That's what @srbarrios did, but it seems he did not remember when he commited again.

And that's understandable. It can happen to anyone.

Such test should be automated, not manual. Not when we commit, and not when we submit the gem, but at all times. Otherwise each PR can break gitarro.

IIRC, we have something in the past but we removed it in favour of mock tests. Time to bring it back?

Originally posted by @juliogonzalez in https://github.com/openSUSE/gitarro/pull/162#issuecomment-465543100

MalloZup commented 5 years ago

This GitHub PR is unactive since more then 30 days. Is this GitHub PR still needed? Please close or update it accordingly. This reminder is autogenerated by https://github.com/MalloZup/blacktango