search

openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

Accept X or x for PR checkboxes, extra whitespaces, and be case-insensitive #171

Closed juliogonzalez closed 5 years ago

juliogonzalez commented 5 years ago

What does this PR do?

Accept X or x for PR checkboxes, extra whitespaces, and be case-insensitive

juliogonzalez commented 5 years ago

Complains from rubocop are unrelated to this PR

MalloZup commented 5 years ago

@juliogonzalez lgtm add a whitelist to rubocop. Update it --auto-gen-config

juliogonzalez commented 5 years ago

@MalloZup I'd say the complains should be researched and maybe we should add the magic comment. I guess it's complaning because of https://stackoverflow.com/a/51634367

I'd say: let's merge, let master fail, let's create a bug, and let's have a loo.

juliogonzalez commented 5 years ago

@srbarrios what other checkboxes?

juliogonzalez commented 5 years ago

Ok, let's merge. I will not release this until #169 is merged.