search

openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

Set upper limit for rubocop version #177

Closed calancha closed 4 years ago

calancha commented 4 years ago

What does this PR do?

Prevent recurrent breakages in our ruby style tests.

From time to time our ruby tests use a newer rubocop version shipping with new cops causing troubles. Fix the maximum rubocop version to prevent breakages.

What issues does this PR fix or reference?

srbarrios commented 4 years ago

@calancha I'm not sure if the problem is here. Fine to fix the version here, but I would bet that our problem is happening in our Uyuni Github actions, which obtain the rubocop version from the latest version available set by the GitHub action.

calancha commented 4 years ago

@calancha I'm not sure if the problem is here. Fine to fix the version here, but I would bet that our problem is happening in our Uyuni Github actions, which obtain the rubocop version from the latest version available set by the GitHub action.

I would also prefer to fix it elsewhere not here. Could you take a look how we can enforce the rubocop version?

srbarrios commented 4 years ago

I checked https://github.com/uyuni-project/uyuni/blob/master/.github/workflows/rubocop.yml#L20, it seems fixed :thinking: Must be something else: https://github.com/uyuni-project/uyuni/runs/1117821703?check_suite_focus=true

Off-topic of this repository, but to put you in context, we have rubocop checks in Uyuni based on a GitHub action. And rubocop checks in spacewalk based on a script contained in gitarro, as our spacewalk is in a private repo.

MalloZup commented 4 years ago

yes I remember the checks. If you want to rubocop fixed for other ruby code, definitely is not here the place to fix it but I am ok here to put fixed rubocop even is not related on the "wanted" behavioural change on other repo.

calancha commented 4 years ago

Currently, we are only affected ay uyuni, so I will abandon this PR and fix it by updating the github action. https://github.com/uyuni-project/uyuni/pull/2614 We might need to think how to handle spacewalk if we are hit there in teh future, but for uyuni we must be OK with the PR above.