openSUSE / gitarro

run all your test against a GitHub Pull request
https://opensuse.github.io/gitarro
MIT License
15 stars 20 forks source link

finish gitarro renaming #42

Closed MalloZup closed 7 years ago

MalloZup commented 7 years ago
juliogonzalez commented 7 years ago

Yes, and at the same time the way of calling the bot should be configurable (and by default the new name).

Right now it's confusing since @gitbot is a mention to a user called gitbot at GitHub, and even more confuse when the users that people use to run gitbot could be different :-D

However keep in mind that when we change the name we will need to:

juliogonzalez commented 7 years ago

Some other (boring) names:

And one 'Spanish':

But I also like gitarro a lot (and it should be easy to make a logo) :-D

juliogonzalez commented 7 years ago

It is easy to pronounce in most languages, it is funny, it is easy to remember, it should be easy to make a logo, and (as you say) it is easy to write on cmdline.

+1 for guitarro :-D

Video: IMAGE ALT TEXT

juliogonzalez commented 7 years ago

Regarding Jenkins Jobs: I think right now they use a gitbot.rb outside the workspace.

I propose making gitarro stable tomorrow, and make a release on monday.

Then we will instruct Jenkins Jobs not using Docker to clone gitarro from the repo each time they run, using the release tag.

And for the jobs using Docker, I will change the Dockerfile to fetch the latest stable available (right now it downloads the last commit available at master), and will rename the images.

Let's discuss it tomorrow.

juliogonzalez commented 7 years ago

Oh, before the release we should consider merging the --change_newer option and the other one to fetch only the commits we need for the tests, instead of the whole repo. Will help a lot with the big repo we have.

juliogonzalez commented 7 years ago

This can now be closed: https://hub.docker.com/r/gitarro/rubocop/tags/ (tested at: https://jenkins.juliogonzalez.es/job/cdtraining-gitbot-test-pr/5/console)