Closed meaksh closed 7 years ago
@MalloZup - I don't know why rubocop is not happy here while he's having a good time locally..
@meaksh, we can ignore rubocop this time. It's a problem from master. @MalloZup is working on it.
@meaksh thx LGTM for me. @juliogonzalez maybe we want to rebase the 2 commits? do we had a policiy for that ? :wolf:
Despite the command is rebase, in this context is best to say "squash".
And if my opinion counts... a PR should only have one commit so we can have the git history clean and easy to read :-)
BTW @meaksh, master is fixed now, so if you rebase the commits from master you will see travis running all the tests without any problem.
@juliogonzalez - Rebased. Let's wait for rubocop 😄
@meaksh thx if rubocop is happy we can go with ti, ! thx for the handy fix!
@meaksh Could you squash the commits into a single one? :-)
Ha! @juliogonzalez - Squashing ;-)
Thanks @meaksh! :-)
@MalloZup ready to merge as soon as the bot is happy about it.
This PR should fix an issue happening when certain repository has failed to be cloned.
On these cases, the following runs of
gitarro
would produce the next traceback during execution:The PR changes the behavior to actually check if the repository path exists. (not only the base git path).
/cc @MalloZup