openSUSE / hwinfo

Hardware information tool
GNU General Public License v2.0
259 stars 70 forks source link

Donot close the open tray after read. #108

Closed yangbonis closed 2 years ago

yangbonis commented 2 years ago

hwinfo --cdrom can close the open tray, correct it

wfeldt commented 2 years ago

is.notready should still be 1 if open() fails. Maybe start with is.notready = 1 and set it to 0 if ioctl(..) == CDS_DISC_OK?

yangbonis commented 2 years ago

is.notready should still be 1 if open() fails. Maybe start with is.notready = 1 and set it to 0 if ioctl(..) == CDS_DISC_OK?

you are right, already update.

wfeldt commented 2 years ago

You're absolutely right; please check https://github.com/openSUSE/hwinfo/pull/109.