search

openSUSE / imagewriter

Utility for writing raw disk images & hybrid isos to USB keys
GNU General Public License v2.0
178 stars 164 forks source link

Tiny fix for windows #1

Closed xarinatan closed 11 years ago

xarinatan commented 11 years ago

Nothing really special, just editted the filedialog filter to also show .iso files, which isn't really vital, but still a small annoyance. Other file changes are because I opened it with Visual Studio 2010 ultimate, which upgraded a few project management files.

Thought I'd push it to you :)

mbarringer commented 11 years ago

I don't doubt that it's a small fix, but it seems that Visual Studio doesn't want to acknowledge how small it is ("700 additions and 660 deletions", according to GitHub). Am I right that this line is the fix, or are there others buried beneath the IDE's file changes :-) ?

xarinatan commented 11 years ago

Yea, that's all really :P Actually it'd be even better if it were this: imageFileDialog.Filter = "Image Files (.raw, *.iso)|.raw;.iso|All files|.*"; Since now the user also gets the option to show any files that are not raw or iso. Hope it's of any use!

mbarringer commented 11 years ago

I don't know, "all files" as a filter just seems wrong somehow. I'll have to think about it :-)

Regardless, I've checked in your original fix, without the Visual Studio changes overhead, so I'll close this pull request. Thanks!

xarinatan commented 11 years ago

Generally, people installing linux know what kind of files can be used as image, and I don't think anyone would blame you if their file doesn't work when explicitly selecting the 'all files' filter, it's just useful to be able to select any file format when it's applicable, but I understand your concern :) It's all upto you in the end. It's a great tool regardless, its simplicity makes it so powerful since it doesn't do any convoluted custom bootloader things like unetbootin does (which usually screws with the layout), so I'm glad I could be of any help!

mbarringer commented 11 years ago

Judging by the emails I get about it, even people who have used Linux for a decade don't always understand that there is a big difference between standard_iso.iso and hybrid_iso.iso, and a simple tool can only handle the hybrid ISO case.

But that makes a good point that filtering on file extensions doesn't really help at all, so I've just added the "All files" option to the Windows file dialog, like you suggested earlier. Thanks :-)

xarinatan commented 11 years ago

Heh, people. I don't know what it's like to have an app of mine used on a scale like that, but I can imagine.. Again, keep up the good work, I and many of my colleagues use the tool daily to make bootable sticks, it's really useful, so thanks! :)