openSUSE / jeos-firstboot

Lightweight firstboot wizard systemd service for SLE and openSUSE JeOS Images
MIT License
14 stars 13 forks source link

Order modules, read from /etc #107

Closed lnussel closed 5 months ago

lnussel commented 10 months ago

ping?

Vogtinator commented 10 months ago

I'll rebase #97. Can you then rebase this on that PR instead?

lnussel commented 10 months ago

if you add 97 that would screw up mine I guess? Would be unfair after a year letting that other thing linger

Vogtinator commented 10 months ago

if you add 97 that would screw up mine I guess?

I thought I wrote in here that this duplicates some parts of #97, but I can't find that comment. Maybe I never submitted it...

Would be unfair after a year letting that other thing linger

IMO this PR is a reason to finish up #97, while previously it was just "nice to have".

lnussel commented 10 months ago

well, you can rebase on this one if you have to rebase anyway :)

Vogtinator commented 10 months ago

well, you can rebase on this one if you have to rebase anyway :)

"Fix calling without installation" is incomplete and I personally don't like type -P $0 or using the ${pfx%/*/*} syntax. At that point it doesn't matter much whether #97 is changed to be more like the commit here or the other way around. I'll just merge them both together and add a Co-authored-by tag. Does that sound good?

lnussel commented 10 months ago

fine with me. calling dirname etc requires external programs for something bash can do by itself. bad style :)

lnussel commented 9 months ago

rebased on yours

lnussel commented 5 months ago

ok now?

lnussel commented 5 months ago

updated