search

openSUSE / jeos-firstboot

Lightweight firstboot wizard systemd service for SLE and openSUSE JeOS Images
MIT License
14 stars 14 forks source link

Use `snapper --no-dbus` on Leap 42.3/SLE12SP3 #14

Closed mnowaksuse closed 5 years ago

mnowaksuse commented 7 years ago 
# we can't use snapper here due to missing dbus daemon in
# firstboot. So we have to create a snapshot manually.
#snapper --no-dbus -v create -d "Factory Status" --userdata "important=yes"
mkdir ".snapshots/$num"
btrfs subvolume snapshot -r / ".snapshots/$num/snapshot"

snapper since version 0.4.0 supports --no-dbus for all commands: http://snapper.io/2016/12/19/no-dbus-for-all.html. Perhaps it can be now used instead of the manual crafting of the snapshot et al.?

Vogtinator commented 6 years ago

I wonder why it has a snapper call above but it's commented out - maybe there is a reason.

@gmoro, @lnussel: Do you remember?

lnussel commented 6 years ago

I guess it just didn't work despite the --no-dbus option

mnowaksuse commented 6 years ago

We test snapper --no-dbus in openQA extensively now. It should work for our use case.

gmoro commented 6 years ago

I think we are safe to assume no older version where this can causes problem will uses later releases of jeos-firstboot, we could try and change that to snapper again and test it.

Vogtinator commented 6 years ago

Actually, after 3d5d163ddbb89737791dc3e712e15fb7898c871e we should have a dbus daemon now.

Vogtinator commented 5 years ago

https://github.com/openSUSE/jeos-firstboot/pull/46 implements this as well.

Vogtinator commented 5 years ago

46 implements this as well.

Which is now merged, so closing