openSUSE / kmozillahelper

KDE mozilla integration

MIT License

17 stars 9 forks source link

Add missing dependencies, install to LIBEXECDIR #10

Open a17r opened 7 years ago

a17r commented 7 years ago

/usr/lib may or may not be a link to lib32/lib64, to me libexecdir seems a better fit.

Adding so far implicit dependencies to cmake.

Vogtinator commented 7 years ago

mozilla-kde.patch does

// not need for lib64, it's a binary
#define KMOZILLAHELPER "/usr/lib/mozilla/kmozillahelper"

so this would break it.

a17r commented 7 years ago

Yeah, that's unfortunate. No problem for me locally, but I don't have an obviously elegant solution for distribution yet. A symlink could serve as a stop-gap measure, for one thing. It's not something that needs to be solved in this PR though, I can drop it and keep the deps change.

wrosenauer commented 7 years ago

libexecdir on openSUSE is /usr/lib basically. That's why

define KMOZILLAHELPER "/usr/lib/mozilla/kmozillahelper"

was fine so far. it could be made a configuration or whatever though but not planning to work on that right now. Taking pull requests towards http://www.rosenauer.org/hg/mozilla/ though.