"Save" isn't reliable ...

openSUSE / kmozillahelper

KDE mozilla integration

MIT License

17 stars 9 forks source link

"Save" isn't reliable ... #12

Closed Brli closed 7 years ago

Brli commented 7 years ago

... When:

Right click on links > Save Link as
Redirect by online storage services ie. Mega, Google Drive etc.
All the others

Reproduce steps:

right click on my avatar
"save image as"
greet with kde prompt
change to a place of your choic, click "Save" (happens even directly press Save)
Nothing happens
- the download toolbar icon (down arrow) doesn't blink
- check the download manager, nothing is done
- check the destination directory, no such file
retry a few times, and it suddenly works

Expected behaviour:

should always be reliable at first time being prompt and confirm saved place.

Vogtinator commented 7 years ago

Any messages in the firefox terminal output messages?

Brli commented 7 years ago

kf5.kio.core: Invalid URL: QUrl("1622084.png")
kf5.kio.core: KSambaShare: Could not find smb.conf!
kf5.kio.core: Invalid URL: QUrl("1622084.png")

Vogtinator commented 7 years ago

Those are kio-internal warnings caused by specifiying the prefilled file name in the dialog and can be ignored. I cannot reproduce the issue here, which version of firefox and kmozillahelper do you use?

Brli commented 7 years ago

kmozillahelper 21af64b firefox 51.0.1 with kde patch but without unity-menubar.patch

Vogtinator commented 7 years ago

Please build kmozillahelper with the "#define DEBUG_KDE" line uncommented and post the output again

Brli commented 7 years ago

COMMAND: GETSAVEFILENAME
kf5.kio.core: Invalid URL: QUrl("1622084.png")
kf5.kio.core: KSambaShare: Could not find smb.conf!
kf5.kio.core: Invalid URL: QUrl("1622084.png")
OUTPUT: 0
OUTPUT: /tmp/1622084.png
OUTPUT: \1
COMMAND: GETPROXY
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "wss"
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "wss"
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
OUTPUT: DIRECT
OUTPUT: \1
COMMAND: GETPROXY
(omitted)

Vogtinator commented 7 years ago

Looks sane to me, kmozillahelper returned the right URL to firefox. Anything beyond this is @wrosenauer territory:

OUTPUT: 0
OUTPUT: /tmp/1622084.png
OUTPUT: \1

Brli commented 7 years ago

lol, thanks for your help. btw, you're on gtk2 build?

my gtk2 build also suffers from this, I don't know why...

Vogtinator commented 7 years ago

I'm currently using a GTK3 build, but I can't remember this being broken at any time...

Brli commented 7 years ago

Upload suffers the same problem, they might be fundamentally related...(not sufficient GTK3 patch?)

Close reason: upstream/different repo that mantains kde patchset

Vogtinator commented 7 years ago

It could also be related to electrolysis, which is disabled here

Brli commented 7 years ago

that maybe it