openSUSE / libsolv

Library for solving packages and reading repositories
http://en.opensuse.org/openSUSE:Libzypp_satsolver
Other
509 stars 151 forks source link

Python binding for repodata.add_solv returns False when should return True #564

Closed dantealmeida closed 1 month ago

dantealmeida commented 1 month ago

Python binding for repodata.add_solv returns False when should return True.

Quick fix:

diff --git a/bindings/solv.i b/bindings/solv.i
index 682d2dcb..f871a819 100644
--- a/bindings/solv.i
+++ b/bindings/solv.i
@@ -4476,7 +4476,7 @@ rb_eval_string(
     r = repo_add_solv(data->repo, fp, flags | REPO_USE_LOADING);
     if (r || data->state == REPODATA_LOADING)
       data->state = oldstate;
-    return r;
+    return r == 0;
   }
   void extend_to_repo() {
     Repodata *data = repo_id2repodata($self->repo, $self->id);
mlschroe commented 1 month ago

Thanks!