search

openSUSE / mentoring

The openSUSE Developer Mentoring Program
http://101.opensuse.org
60 stars 49 forks source link

Accordion header '+' image missing alt attribute #213

Closed adritek closed 3 months ago

adritek commented 4 months ago

Project Title: Uyuni Website Refresh - Accessibility and Responsiveness (#205)

Accessibility/Responsive Issue

Page
Home/landingpage

Description
Alt text is missing on the image tags for the '+' svgs on the accordion section headers

Proposed Solution
This is an interesting one, because there's a couple ways to think about it... The accordion is already open and displays the description under the title to the user - is the '+' an icon as in, does it convey meaning, or is it decorative. A '+' would universally be understood as addition, but in the context of a collapsible accordion maybe a 'v' is more informative for 'expand' and '^' for 'collapse would be a better choice. Or are we trying to build semantic markup.

Solutions Solution 1 (quick): Give the in the accordions an alt attribute. Solution 2 (semantic): Pull the tag out of the image, and use aria-hidden (if decorative) and role attributes.

Additional Notes

Screenshot
Screen Shot 2024-05-09 at 1 22 43 am

ddemaio commented 3 months ago

Hi @adritek GSoC already selected the projects listed. These all were added after the selections were made. Is there something specific you are using all these issues you've added for? Should I close them?

adritek commented 3 months ago

Thanks for responding @ddemaio - The TLDR is: I made a bunch of WCAG accessibility issues under the wrong repo, and they need to be transferred to the right repo.

The issues I raised were all incorrectly made under mentoring, and I should have put them under Uyuni project. I cannot transfer them to the appropriate project (understandably), are you able to do this? And apologies.

deneb-alpha commented 3 months ago

moved to https://github.com/uyuni-project/uyuni-project.github.io/issues/111