search

openSUSE / microos-toolbox

Script to run a toolbox container on openSUSE MicroOS
Apache License 2.0
54 stars 15 forks source link

Dynamically set REGISTRY and IMAGE #11

Closed brunoleon closed 3 years ago

brunoleon commented 3 years ago

Determine the underlying os from /etc/os-release if present and set variables accordingly Exit if not openSUSE or SUSE

thkukuk commented 3 years ago

With this change, we have now two hardcoded values. And later we have to add another one for SLE Micro 6.0. And then for 7.0, ... That's why I wouldn't hardcode the values, but use a default for openSUSE. What I would do is: REGISTRY=registry.opensuse.org IMAGE=opensuse/toolbox [....] test -f /etc/toolboxrc && . /etc/toolboxrc And toolboxrc can overwrite REGISTRY and IMAGE

brunoleon commented 3 years ago

Updated code to use a config file instead of "dynamic detection"