search

openSUSE / microos-toolbox

Script to run a toolbox container on openSUSE MicroOS
Apache License 2.0
54 stars 15 forks source link

Fix problem with creating containers with -c flag #21

Closed jlausuch closed 3 years ago

jlausuch commented 3 years ago

Addresses: https://github.com/kubic-project/microos-toolbox/issues/19

When trying to create a toolbox container with -c option and without -t, it complains that -c and -t can't be given at the same time.

jlausuch commented 3 years ago

@dfaggioli @thkukuk could you please take a look?

dfaggioli commented 3 years ago

@dfaggioli @thkukuk could you please take a look?

It looks fine to me. To the point, that I made the very same change, as part of my own pull request:

https://github.com/kubic-project/microos-toolbox/pull/20/commits/5d40666b5d5ea0972d662533eaf6c8edb5f55c4b

:-D

@thkukuk I'm absolutely fine with this patch being picked up instead of mine (they're basically identical)... Whatever is more practical

thkukuk commented 3 years ago

The other pull request contains an additional error checking, that's why I used that.

jlausuch commented 3 years ago

@dfaggioli @thkukuk could you please take a look?

It looks fine to me. To the point, that I made the very same change, as part of my own pull request:

5d40666

Ooops, I didn't see that one, sorry :)