search

openSUSE / obs-build

OBS build script, can be used with OBS or stand alone
GNU General Public License v2.0
130 stars 181 forks source link

fix: handle trailing slashes in BUILD_ROOT path comparison #1009

Open myml opened 1 month ago

myml commented 1 month ago

In the current implementation, we compare the MYSRCDIR variable with a constructed path using the BUILD_ROOT variable. This comparison can fail if BUILD_ROOT ends with a trailing slash(eg. In KVM, BUILD_ROOT is set to '/'), causing copy behavior.

adrianschroeter commented 1 week ago

hm, we should do this in a single place IMHO. best would be at the argument parsing in build itself

mlschroe commented 1 week ago

Isn't that no longer needed as of commit dca0e07939ad80f2920d6e771447687aebdfe1bc ?