search

openSUSE / obs-build

OBS build script, can be used with OBS or stand alone
GNU General Public License v2.0
130 stars 181 forks source link

Pass release for reproducible builds when testing #982

Closed JanZerebecki closed 4 months ago

JanZerebecki commented 4 months ago

also enabling changelog handling and move changelog to changes file, to more closely do what OBS does normally.

Passing a release might become required in the future on distributions that have reproducible builds enabled, as otherwise SOURCE_DATE_EPOCH_MTIME can not be computed. rpms build without that would result in a hard to notice failures of tools that rely on mtimes like rsync without --checksum.

JanZerebecki commented 4 months ago

CI failure is false positive, the blank line is necessary. One could disable that check by replacing the invocation with: git --no-pager -c core.whitespace=-blank-at-eof diff --check origin/master..HEAD --

JanZerebecki commented 4 months ago

rebased on top of https://github.com/openSUSE/obs-build/pull/981

JanZerebecki commented 4 months ago

On second thought it would be better if osc build worked without a release argument. Not sure yet, how to make osc build succeed and obs fail without a release...