search

openSUSE / obs-service-download_files

An OBS source service: download files
GNU General Public License v2.0
8 stars 23 forks source link

RPM macro "%{_arch}" in source URL is not evaluated #22

Open okurz opened 6 years ago

okurz commented 6 years ago

Observation

https://build.opensuse.org/request/show/560971 fails because the source validator fails to parse the rpm macro %{_arch} and therefore rejecting the SR.

Steps to reproduce

osc bco network:telephony skype
osc service localrun download_files

Problem

Seems like https://github.com/openSUSE/obs-service-download_files/blob/master/download_files#L225 evaluates RPM macros but not %{_arch}?

okurz commented 6 years ago

Is there a workaround possible?

marcus-h commented 6 years ago

On 2018-01-03 08:26:58 +0000, Oliver Kurz wrote:

Observation

https://build.opensuse.org/request/show/560971 fails because the source validator fails to parse the rpm macro %{_arch} and therefore rejecting the SR.

Hmm we could adapt the obs-service-source_validator to consider the %{_arch} macro, but IMHO this would be wrong in general, because

  • the resulting src.rpm is arch specific (no problem in your case, but in general)
  • the result of a source validator run depends on the arch on which the source validator is executed

@DimStar77: is it correct that the source validator complains in this case?

As a workaround/fix: replace %{_arch} with x86_64 in the Source0 tag.

DimStar77 commented 6 years ago

Erm.. Mis clicked... So again a summary: As pointed out by @Marcus-h, the src.rpm would result being differnt depending on arch this is built on.

The right thing, after thinking about it, would probably be to avoid the arch macro and list the supported ones as source1..source(n) (they have to be in parallel to an ExclusiveArch anyway, as any nonlisted arch would potenitally lead to a non existing source anyway... )

okurz commented 6 years ago

ok, I replaced the macro with explicit statement of x86_64. If you don't want to act on this issue in any way, e.g. improve the error feedback, we could close the issue.