search

openSUSE / obs-service-node_modules

MIT License
7 stars 11 forks source link

Rename service file to be usable #5

Closed sebd71 closed 3 years ago

sebd71 commented 3 years ago

Having .py extension set prevents OBS to correctly detect and use this service.

lnussel commented 3 years ago

Any reason for this? When installing I rename this in the spec file?

sebd71 commented 3 years ago

The reason is that I installed manually this plugin on a private instance of OBS sever using following commands :

cd /usr/lib/obs/service/
git clone https://github.com/openSUSE/obs-service-node_modules
ln -s ./obs-service-node_modules/node_modules.py      <<<<  Doesn't work
ln -s ./obs-service-node_modules/node_modules.service

Then I just recreate link as follow

ln -s ./obs-service-node_modules/node_modules.py  ./node_modules

I did that because you only package obs-service-node_modules for Tumbleweed and the other reason is that our internal OBS server still run openSuse 15.1!

Anyway, feel free to close/cancel this pull request if you consider that it's better to rename file name in spec file.

Regards.

AdamMajer commented 3 years ago

Yes, this should be closed.

The service can be installed on any OS irrespective of what distro it's "built for" since all the RPM does is install a single python source. There is nothing build per-se.