Does not support all valid RPM versions

openSUSE / obs-service-replace_using_package_version

An OBS service to replace a regex with some package version available in the build time repositories

GNU General Public License v3.0

4 stars 12 forks source link

Does not support all valid RPM versions #47

Closed Vogtinator closed 1 year ago

Vogtinator commented 1 year ago

opensuse-dhcp-server-image fails now because this warning is now an error:

[   48s] /usr/lib/python3.10/site-packages/pkg_resources/__init__.py:123: PkgResourcesDeprecationWarning: 4.4.2.P1 is an invalid version and will not be supported in a future release

dcermak commented 1 year ago

Hm, python is not wrong here… What would you recommend to do here? Just fall back to the previous behavior and take anything as a valid version?

Vogtinator commented 1 year ago

Hm, python is not wrong here…

Technically it isn't, because the module is only meant to compare python package versions. It's unsuitable to compare RPM package versions, which can be pretty much anything.

What about using rpm.labelCompare instead?