search

openSUSE / obs-service-source_validator

The default source validator as used by openSUSE:Factory distribution
GNU General Public License v2.0
3 stars 28 forks source link

Slow validation for repo with many flavors #103

Closed marxin closed 1 year ago

marxin commented 2 years ago

We started using _multibuild for binutils and I noticed every commit is very slow. It's due to /usr/lib/obs/service/source_validators/helpers/spec_query --specfile /home/marxin/BIG/osc/home:marxin:branches:devel:gcc/binutils/cross-avr-binutils.spec --print-subpacks --buildflavor cross-pru-binutils that is run for every spec file any possible flavor (N^2). I think it should be run only for valid combinations like cross-avr-binutils.spec and --buildflavor cross-avr-binutils.

marxin commented 1 year ago

The same happens in https://build.opensuse.org/package/show/devel:gcc/gcc13 where we have quite some multibuild targets: https://build.opensuse.org/package/view_file/devel:gcc/gcc13/_multibuild?expand=1

The verification takes ~2.5 minutes, please see the log file: log.txt

and so each osc build and osc commit is reallly slow.