search

openSUSE / obs-service-source_validator

The default source validator as used by openSUSE:Factory distribution
GNU General Public License v2.0
3 stars 28 forks source link

source_validator fails on mysql-workbench/openSUSE_(Vendor_Package).xml #38

Open plusky opened 8 years ago

plusky commented 8 years ago

In 407821 fails with:

Source validator failed. Try "osc service localrun source_validator" Invalid input file name found: 'mysql-workbench/openSUSE_(Vendor_Package).xml' Source validator failed. Try "osc service localrun source_validator"

Note that openSUSE_(Vendor_Package).xml is valid file name, and was in previous version accepted to Factory (accepted successfully at 2015-06-24)

marcus-h commented 8 years ago

On 2016-07-11 14:11:53 -0700, Martin Pluskal wrote:

Note that openSUSE_(Vendor_Package).xml is valid file name, and was in previous version accepted to Factory (accepted successfully at 2015-06-24)

That's due to commit 36bd3a21c3aa5b621b7721d2de5e8003747363ed. I agree that the current check is pretty conversative, but this way we reduce the chance of, for instance, code "injection". Is renaming the file an option for you?:)