openSUSE / obs-service-tar_scm

An OBS source service: fetches code from any SCM and archives it
GNU General Public License v2.0
31 stars 105 forks source link

Error with Python 3.12 due to deprecated and removed 'readfp' usage #474

Closed bluca closed 1 year ago

bluca commented 1 year ago

readfp has been deprecated since Python 3.2, and read_file should be used instead. In a Fedora Rawhide build (with Python 3.12 beta) using obs_cpio:

[   37s]   File "/usr/lib/obs/service/tar", line 30, in <module>
[   37s]     main()
[   37s]   File "/usr/lib/obs/service/tar", line 26, in main
[   37s]     TarSCM.run()
[   37s]   File "/usr/lib/obs/service/TarSCM/__init__.py", line 39, in run
[   37s]     task_list.process_list()
[   37s]   File "/usr/lib/obs/service/TarSCM/tasks.py", line 132, in process_list
[   37s]     self.process_single_task(task)
[   37s]   File "/usr/lib/obs/service/TarSCM/tasks.py", line 212, in process_single_task
[   37s]     self.scm_object = scm_object   = scm_class(args, self)
[   37s]                                      ^^^^^^^^^^^^^^^^^^^^^
[   37s]   File "/usr/lib/obs/service/TarSCM/scm/base.py", line 82, in __init__
[   37s]     self._calc_repocachedir()
[   37s]   File "/usr/lib/obs/service/TarSCM/scm/base.py", line 234, in _calc_repocachedir
[   37s]     repocachedir = Config().get('tar_scm', 'CACHEDIRECTORY')
[   37s]                    ^^^^^^^^
[   37s]   File "/usr/lib/obs/service/TarSCM/config.py", line 47, in __init__
[   37s]     self.configs.append(self._init_config(fname))
[   37s]                         ^^^^^^^^^^^^^^^^^^^^^^^^
[   37s]   File "/usr/lib/obs/service/TarSCM/config.py", line 73, in _init_config
[   37s]     config.readfp(tmp_fp)
[   37s]     ^^^^^^^^^^^^^
[   37s] AttributeError: 'RawConfigParser' object has no attribute 'readfp'. Did you mean: 'read'?
[   37s] service run failed for service 'tar'
[   37s] ### VM INTERACTION START ###
Vogtinator commented 1 year ago

https://github.com/openSUSE/obs-service-tar_scm/pull/475

bluca commented 1 year ago

Thanks!