Missing handling of scmsync packages for token operations

[darix]

Issue Description

NoMethodError (undefined method `+' for nil:NilClass

    package_name += ':' + options[:multibuild_flavor] if options[:multibuild_flavor]
                 ^):

app/models/token/rebuild.rb:5:in `call'
app/controllers/trigger_controller.rb:36:in `block in create'
app/models/user.rb:856:in `run_as'
app/controllers/trigger_controller.rb:31:in `create'
config/initializers/prefer_xml_over_html.rb:15:in `call'

This means app/controllers/concerns/triggerable.rb will probably need to learn about scmsync packages

also

return unless @project.links_to_remote? in def set_package(package_find_options: {}) is weird ... IMHO the code should either raise an exception. it seems code further down the chain is not expecting nil and checking for it.

Expected Result

rebuild triggered

How to Reproduce

1. osc token --trigger <TOKEN> --operation rebuild scmsyncbasedproject python311:base

Further Information

• A link to an OBS instance showing the issue
• Exact server version (in case a private instance is used)

[fcrozat]

This bug is preventing us to switch ALP codestream to direct rebuild with tooling in botmaster to trigger rebuild if needed (similar to Factory). And it is adding additional load to autobuild team who are currently the only one able to trigger rebuild of specific packages in ALP codestream.

Would it be possible to prioritize a fix for this ? Thanks

[adrianschroeter]

this should be fixed in internal system since quite some time... are you sure it is not working? Please reach out directly then.

Also, please do not use github tracker for buisiness critical requests, things may slip here.

[adrianschroeter]

https://github.com/openSUSE/open-build-service/pull/15433

[fcrozat]

this should be fixed in internal system since quite some time... are you sure it is not working? Please reach out directly then.

Since there was no action on this issue, I assume it was still in limbo. But it seems indeed to be fixed (just tested).

Thanks and will do better next time.