openSUSE / open-build-service

Build and distribute Linux packages from sources in an automatic, consistent and reproducible way #obs
https://openbuildservice.org
GNU General Public License v2.0
925 stars 436 forks source link

Improve deleting of comments #2573

Open coolo opened 7 years ago

coolo commented 7 years ago

Deleting a lot of comments is really really problematic. For once, you have to delete it one by one - but that would be ok, if:

ChrisBr commented 7 years ago

@coolo deleting is now done by AJAX. However, the confirmation popup I don't want to change without more discussions. This is the Rails default and also done on other places in OBS (also other sites use it extensively, e.g. deleting comments on GitHub).

coolo commented 7 years ago

I didn't talk about deleting the popup - I was talking about changing it to inline confirmation. The alert works for deleting single comments - but if you have to fight a spammer[1], it's becoming problematic :)

[1] https://build.opensuse.org/project/show/devel:openQA

ChrisBr commented 7 years ago

@coolo can you please elaborate what you mean with inline confirmation? Can't really follow ... :fearful:

coolo commented 7 years ago

after clicking on delete, there appears a confirmation link close to the original position - http://bootstrap-confirmation.js.org/