openSUSE / open-build-service

Build and distribute Linux packages from sources in an automatic, consistent and reproducible way #obs
https://openbuildservice.org
GNU General Public License v2.0
925 stars 436 forks source link

2.4.2: webui URI::InvalidURIError #332

Closed KostyaSha closed 6 years ago

KostyaSha commented 11 years ago
[INFO |#22123] Processing by PackageController#binary as HTML
[INFO |#22123]   Parameters: {"arch"=>"x86_64", "filename"=>"PROJECT-10.9-bareOS.x86_64-0.1.0-Build<<
SPEC_REL>.1.iso", "package"=>"project-image-pxe", "project"=>"PROJECT:trunk:PROJECT",
 "repository"=>"images"}
[INFO |#22123] Authenticated request to "/package/binary?arch=x86_64&filename=PROJECT-10.9-bareOS.x88
6_64-0.1.0-Build%3CSPEC_REL%3E.1.iso&package=project-image-pxe&project=PROJECT%3Atru
nk%3APROJECT&repository=images" from kshautsou
[INFO |#22123] Completed 500 Internal Server Error in 196ms

[FATAL|#22123] URI::InvalidURIError (bad URI(is not URI?): http://obs-server.domain.com:82//PP
ROJECT:/trunk:/PROJECT/images/iso/PROJECT-10.9-bareOS.x86_64-0.1.0-Build<SPEC_REL>.1
.iso):
  app/controllers/package_controller.rb:1073:in `file_available?'
  app/controllers/package_controller.rb:132:in `binary'

Yes, file is available.

coolo commented 11 years ago

some more context would be nice - e.g. the version you deplyoed

KostyaSha commented 11 years ago

2.4.2_20 (my fedora branch but i have no modifications for this part of code). Error appears when i'm clicking on file name in kiwi build results listing (5 other file are ok). I.e. https://build.opensuse.org/package/binaries/OBS:Server:2.4/OBS-Appliance?repository=images The only that i have in all filenames , but 5 files are ok and only one fails... When i enter url from (bad URI(is not URI?) browser starts download, so URI is ok.

hennevogel commented 10 years ago

Related to #334 obviously...

KostyaSha commented 10 years ago

No, all info in log is valid, obs can't process url when file has `&lt;SPEC_REL&gt; in it's name. File was valid and even published. Probably something doesn't escape url...

eduardoj commented 6 years ago

As 2.4.2 is not supported anymore I will close this. Please, feel free to open it if this is still happening in a supported version.

Checked https://build.opensuse.org/package/binaries/OBS:Server:2.4/OBS-Appliance?repository=images and all the links are working. Please provide another example if it is still happening.