search

openSUSE / open-build-service

Build and distribute Linux packages from sources in an automatic, consistent and reproducible way #obs
https://openbuildservice.org
GNU General Public License v2.0
935 stars 438 forks source link

Status::Check.name format #6075

Open hennevogel opened 6 years ago

hennevogel commented 6 years ago

We require that you delete check by name.

DELETE /status_reports/projects/<project>/required_checks/<check>

Which means there are restrictions on what the name can be. You can urlencode a lot, but not everything (like /). Either we are a bit more strict of what names can contain or we switch to the body.

coolo commented 6 years ago

Why not make it like the comments? a GET on /required_checks outputs the ID and DELETE acts only on IDs. I sure hope most required checks will be deleted from within the UI

coolo commented 6 years ago

I realize now required checks don't have IDs. That makes it a little complicated. Leaves IMO to drop the DELETE route and only offer UPDATE/PUT to delete things (like we do for _meta)