Open jengelh opened 5 years ago
(Tabbing out of the
(Tabbing out of the
https://xkcd.com/1172/ :full_moon_with_face:
https://xkcd.com/1172/ full_moon_with_face
As silly as the GNOME HIG presenting command buttons in reverse order may seem to some, at least they got tabbing right in the reference implementation (GTK). ;-)
Thanks much for reporting these issues. Much appreciated.
The location of the buttons is intended. Most (or many) of the primary buttons in the old UI were already on the right and in buttons we now want the streamline that. But you are right, we should handle the tabbing work better.
But you are right, we should handle the tabbing work better.
After trying this out in the UI I am not that sure anymore. Having the tabbing go from right to left when it comes to buttons is probably unexpected for most users as well. It was at least for me.
So I would say we should leave it as is. What do you think?
I find the left alignment of these buttons rather strange. I can't think of any other UI that has buttons at the left side. Together with the button order, it puts the default action in the middle of the screen.
I find the left alignment of the button the right thing. The mouse pointer is likely to be on the left half of the screen already, e.g. when
<body>
or some <code>
element to put focus there (setting it as the "active" HTML element makes keyboard navigation within the element available)Unless one is a national of a RTL-language country, the muscle memory will favor the left side, let alone the eyes. This is why verticla ad banners on websites elsewhere are commonly found on the right-hand side.
I would plainly trust years of research on this matter - and even if everyone else is wrong, just do it for consistency reasons. Do you see this very form here in github?
Since when is github a measure? https://features.opensuse.org/306282 - left side https://sourceforge.net/p/gsoap2/patches/174/ - left side http://freshcode.club/submit/beebeep - left side https://bugzilla.opensuse.org/show_bug.cgi?id=1127790 , twitter, facebook - messy mix of left and right. Technically speaking, there are elements on the LHS (text or icons or both) that kind of force the buttons to the right unwillingly. (phpBB 3.2 demo page) - center
All your examples (that didn't require login) only have on button that you end your workflow with. But as soon as you have 2 choices, it's a different story
At least GH gets the tab order right (which, looking at it with w3m, is done by placing the default action first HTML-wise, and then using CSS to reorder them).
@jengelh I think we will find examples for both solutions, the most important is to be consistent
i.e:
gitlab
google chrome
google chrome upload file
Of course I am with you on the "consistency" thought: No third-party website has a left-aligned Cancel-OK combo. PR #7300 would have fixed that and restored consistency at least with one half of the Internet.
@jengelh We all agree that to let a dialog with a different alignment doesn't make sense, right? The issue can still be open, until we finish the whole bootstrap migration, and then we can revisit this issue. The PR #7300 IMO doesn't make sense now or in a so limited scope.
then you do not want the buttons to change it sideways, you want to keep the buttons as they are?
The issue can still be open, until we finish the whole bootstrap migration
This thing has now been broken for a month, and you have not come up with any ready-to-merge counterproposal. This is basically admitting complete defeat. This should be merged, because as everybody knows, software projects and their visions for complete overhauls have a tendency to drag on and sometimes even languish in oblivion.
Observed
The Decline button is on the left hand-side, which suggests it is the primary action.![buttons](https://user-images.githubusercontent.com/8861948/54754472-e699a880-4be3-11e9-89b6-52cefcbde729.png)
Expected Result
The Approve button should be immediately left of the Decline button.
How to Reproduce
Further Information
Regression caused by https://github.com/openSUSE/open-build-service/pull/7233