openSUSE / openSUSE-release-process

Other
8 stars 9 forks source link

[15.4 Retro] review bot for Backports #109

Closed nilxam closed 1 year ago

nilxam commented 2 years ago
nilxam commented 1 year ago

https://github.com/openSUSE/openSUSE-release-tools/pull/2848

then we need to add factory-auto to be reviewer on Backports project, and add it to every pending requests.

nilxam commented 1 year ago

Project attributes in my test project:

check-source-ensure-source-exist-in-baseproject: True
check-source-devel-baseproject: openSUSE:Factory
check-source-allow-source-in-sle: False
check-source-sle-project: SUSE:SLE-15-SP5:GA
check-source-allow-valid-source-origin: True
check-source-valid-source-origins: openSUSE:Leap:15.4:Update openSUSE:Backports:SLE-15-SP4:Update openSUSE:Factory openSUSE:Backports:SLE-15-SP5:SLEFork openSUSE:Backports:SLE-15-SP5:FactoryFork
check-source-add-devel-project-review: True
review-team = origin-reviewers
nilxam commented 1 year ago

Backports checker is up for openSUSE:Backports:SLE-15-SP5!!

Scenarios:

  1. FOO submitted from openSUSE:Factory to openSUSE:Backports:SLE-15-SP5

    • New package(Yes): add devel-project review
    • New package(No): no additional review needed, when it passes Factory review would mean passes opensuse-review-team's review
  2. FOO submitted from home namespace or any other project than openSUSE:Factory to openSUSE:Backports:SLE-15-SP5

    • If FOO does exist in SLE: decline the submission, Backports maintainer can override it by commenting on the request(eg. @factory-auto override accept then reopen the request)
    • If FOO does not exist in Factory": decline the request and ask submitter to submit it to Factory first
    • If FOO does exist in Factory: add origin-reviewers review
nilxam commented 1 year ago

This is fixed a while ago.