Shut down useless bots and drop obsolete code

[ancorgs]

There are several tools marked as obsolete in CONTENTS.md. So we plan to drop those tools by:

• Shutting them down from botmaster (gocd)
• Removing them from the spec file used for the package at OBS
• Dropping the code from the repository (the tools will always live in our hearts and in git's history)

This is the list of tools and the rationale for dropping them:

• check_maintenance_incidents (alias maintbot) - Looks like a very outdated script obsoleted by origin-manager. BEWARE maybe is not obsolete (see https://github.com/openSUSE/openSUSE-release-tools/pull/2610)
• check_source_in_factory - Outdated, it was decided to drop it bit it never happened. BEWARE it is still being called from check_tags_in_requests.
• obs-operator - Not so simple. See #2614
• leaper - Obsoleted by origin-manager. Currently deployed in comment-only mode for the maintenance workflow, but it's also useless there
• unmaintained - Not longer used, based on data created by leaper
• sync-rebuild - The code was merged to the 'accept' command
• update_crawler - Obsoleted by origin-manager.
• manager_42.py - Apparently obsoleted by origin-manager. Currently not deployed.
• status - Apparently obsolete since it checks for bots that are already retired
• obs-clone - Was used by Jimmy to create tests, but we use the OBS docker-compose approach now.
• scan_baselibs - Introduced to debug a specific problem that should not happen again since the introduction of an OBS fix.

[dirkmueller]

I have no concerns with the list.

[boombatower]

* obs-operator - Nobody seems to be using it nowadays

This is a requirement for the origin manager web interface that provides release managers an overview of what origin-manager sees and allows them to submit requests to change origins. At some point the server setup was broken and no one fixed it (likely since I left). I believe the openSUSE k8s cluster was rehosted and the setup was lost.

The web interface may be accessed at https://osrt.opensuse.org/web/origin-manager/.

I can answer questions, but everything was hosted via the k8s setup so it should be simple enough to either a) revive that in a different config language, or b) just use the container somewhere else.

The interface may be used by anyone with an OBS login, so it also provides an easy way for contributors to submit their packages to Leap.

[boombatower]

The operator also enables the use of the userscripts. Most relevant one now is the one to add origin information to package pages on OBS.

[boombatower]

* check_maintenance_incidents (alias maintbot)

As long as maintenance finally switched over to origin manager.

[deneb-alpha]

There are several tools marked as obsolete in CONTENTS.md. So we plan to drop those tools by:

I'm still checking... sorry for being slow. I also asked to colleagues from Security and Maintenance to have a look at the list.

This is the list of tools and the rationale for dropping them:

* check_maintenance_incidents (alias maintbot) - Looks like a [very outdated script](https://github.com/openSUSE/openSUSE-release-tools/pull/2604#discussion_r674063873) obsoleted by origin-manager. **BEWARE** maybe is not obsolete (see [do not add factory-auto to backports reviews anymore #2610](https://github.com/openSUSE/openSUSE-release-tools/pull/2610))

it should be still used. see as example https://build.opensuse.org/request/show/908856

* check_source_in_factory - Outdated, it was [decided to drop it](https://github.com/openSUSE/openSUSE-release-tools/pull/2604#discussion_r674046338) bit it never happened. **BEWARE** it is still being called from [check_tags_in_requests](https://github.com/openSUSE/openSUSE-release-tools/blob/3990fecd037e4a/check_tags_in_requests.py#L91).

not sure this can be dropped

* leaper - Obsoleted by origin-manager. Currently deployed in comment-only mode for the maintenance workflow, [but it's also useless there](https://github.com/openSUSE/openSUSE-release-tools/pull/2604#discussion_r674031669)

still used. see for example https://build.opensuse.org/request/show/908856

[ancorgs]

* check_source_in_factory - [...]

not sure this can be dropped

Well, it's only deployed for Leap 15.0. It currently does not scan any other project/distribution. At least directly, it still could be used indirectly through check_tags_in_requests, but that's other story.

* leaper - [...]

still used. see for example https://build.opensuse.org/request/show/908856

We know it is deployed for maintenance requests. But as far as I understood, the comments it is adding are useless because it was never really adapted to the maintenance use case. Look at the example you provided: "expected origin is 'None' (unchanged)". Leaper basically writes the same "expected origin is None" comment in every single request.

The question is: do you really read and use the comments added by leaper? That's the real question, not whether is deployed or not.

[boombatower]

If memory serves you are correct with regard to leaper comments.

[ancorgs]

Thanks to all the feedback, the original list of stuff to drop was modified as shown in #2613. In summary:

• check_maintenance_incidents (alias maintbot) was absolved
• check_source_in_factory will be kept, although it will not longer be deployed standalone
• obs-operator will be kept until we find a better way to deploy the userscripts and the web front-end
• death to all the rest!

This issue has been open for almost two months. I would like to execute the sentence (a.k.a. merge #2613) this week. So speak now or stay silent forever... well, we can always recover stuff, that's what we have git for.

[coolo]

we removed the parts that we could. the obs-operator is still kind of useless without anyone actually needing it. I would still leave it because the next big project may need something alike and then we don't need to start from scratch. So documenting it's state of being dead is all we can do atm (and we have an issue for that)