search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
61 stars 95 forks source link

Handle deletion of packages with _multibuild (#2943) #2945

Closed Vogtinator closed 1 year ago

Vogtinator commented 1 year ago

Also consider its multibuild flavors for deletion.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (1cf4e6b) 28.45% compared to head (54b1c72) 28.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2945 +/- ## ========================================== - Coverage 28.45% 28.41% -0.05% ========================================== Files 84 84 Lines 14509 14540 +31 ========================================== + Hits 4129 4131 +2 - Misses 10380 10409 +29 ``` | [Impacted Files](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [staging-installcheck.py](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-c3RhZ2luZy1pbnN0YWxsY2hlY2sucHk=) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2945/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Vogtinator commented 1 year ago

With this, deletion of rust1.65 is accepted (previously wasn't) while deletion of webkit2gtk3 is not (previously was).

DimStar77 commented 1 year ago

With this, deletion of rust1.65 is accepted (previously wasn't) while deletion of webkit2gtk3 is not (previously was).

That sounds like a very welcome and correct change (I assume it would have accepted wk del req because the "" flavor does nothing)

Vogtinator commented 1 year ago

With this, deletion of rust1.65 is accepted (previously wasn't) while deletion of webkit2gtk3 is not (previously was).

That sounds like a very welcome and correct change (I assume it would have accepted wk del req because the "" flavor does nothing)

Yep!