openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
61 stars 95 forks source link

Rewrite cleanup_rings.py #2946

Closed Vogtinator closed 1 year ago

Vogtinator commented 1 year ago

Previously it went through each package's provides->required_by chain. This does not deal with cycles correctly and there was only a hack to deal with single-package cycles.

Instead, recursively walk through all required packages, starting from the build enabled images and take note of all needed source packages. This also handles _multibuild flavors as separate packages.

Depends on #2944.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (4a241c4) 25.40% compared to head (b7751b7) 25.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2946 +/- ## ========================================== - Coverage 25.40% 25.36% -0.05% ========================================== Files 84 84 Lines 14548 14573 +25 ========================================== Hits 3696 3696 - Misses 10852 10877 +25 ``` | [Impacted Files](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [osclib/cleanup\_rings.py](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-b3NjbGliL2NsZWFudXBfcmluZ3MucHk=) | `0.00% <0.00%> (ø)` | | | [osclib/core.py](https://codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-b3NjbGliL2NvcmUucHk=) | `58.56% <0.00%> (-0.29%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Vogtinator commented 1 year ago

[09:42] fvogt: STaging:O installcheck looks good with that new list

Vogtinator commented 1 year ago

Staging :O with the proposed changes is happy