openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

skippkg-finder.py: Handle empty configuration values properly #2973

Closed Vogtinator closed 1 year ago

Vogtinator commented 1 year ago

Splitting an empty string with ' ' results in list(""), which the code does not handle properly. Instead use just split() which returns an empty list() insted.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -6.68 :warning:

Comparison is base (d798b51) 28.22% compared to head (df4782d) 21.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2973 +/- ## ========================================== - Coverage 28.22% 21.55% -6.68% ========================================== Files 85 85 Lines 14634 14634 ========================================== - Hits 4131 3154 -977 - Misses 10503 11480 +977 ``` | [Impacted Files](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2973?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [skippkg-finder.py](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2973?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-c2tpcHBrZy1maW5kZXIucHk=) | `0.00% <0.00%> (ø)` | | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/2973/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.