openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

Add test for publish_distro #2989

Open andrii-suse opened 1 year ago

andrii-suse commented 1 year ago

I am investigating how to improve publish_distro script, so having some kind of tests with debug output will help to track what exactly changes.

Vogtinator commented 1 year ago

I'm wondering to which extent tests on this level actually work in practice. If the design and mechanisms are changed like #2954, then this might not be the case...

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@3bf8fdf). Learn more about missing BASE report. Report is 296 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2989 +/- ## ========================================= Coverage ? 28.45% ========================================= Files ? 85 Lines ? 14698 Branches ? 0 ========================================= Hits ? 4183 Misses ? 10515 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrii-suse commented 1 year ago

I'm wondering to which extent tests on this level actually work in practice. If the design and mechanisms are changed like #2954, then this might not be the case...

My understanding that it is OK if tests sometimes don't cover everything. And It is good if they cover at least something and help to visually track changes in functionality.

lkocman commented 1 year ago

I mean I'm supportive of any test coverage, however, ... I was hoping we'd eventually replace what we have :-)