search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

factory-package-news: support newer python3 rpm bindings #3002

Closed g7 closed 1 year ago

g7 commented 1 year ago

rpm's python bindings changed in version 4.15 [0] so that they actually return utf-8 strings. Handle this case while keeping support for the older bindings such as the ones shipped with Leap 15.

[0] https://github.com/rpm-software-management/rpm/commit/84920f898315d09a57a3f1067433eaeb7de5e830

g7 commented 1 year ago

v2: addressed flake8 warnings :)

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (82c067d) 28.45% compared to head (17f0cd5) 28.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3002 +/- ## ======================================= Coverage 28.45% 28.45% ======================================= Files 85 85 Lines 14716 14716 ======================================= Hits 4188 4188 Misses 10528 10528 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dirkmueller commented 1 year ago

test are passing, we can solve the nit anytime..