openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

cleanup_rings: keep docker-buildx for QA tests #3012

Closed DimStar77 closed 11 months ago

DimStar77 commented 11 months ago

Question actually: it being on the DVD is sufficient for cleanup_rings NOT to want to throw it away?

codecov-commenter commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (37393de) 28.48% compared to head (f61c3ef) 28.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3012 +/- ## ======================================= Coverage 28.48% 28.48% ======================================= Files 85 85 Lines 14717 14717 ======================================= Hits 4192 4192 Misses 10525 10525 ``` | [Files Changed](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/3012?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [osclib/cleanup\_rings.py](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/3012?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-b3NjbGliL2NsZWFudXBfcmluZ3MucHk=) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Vogtinator commented 11 months ago

Question actually: it being on the DVD is sufficient for cleanup_rings NOT to want to throw it away?

Yes, it should be

DimStar77 commented 11 months ago

Question actually: it being on the DVD is sufficient for cleanup_rings NOT to want to throw it away?

Yes, it should be

Then let's not merge it yet - I'll update the 000package groups in Factory/ring1 (once the current snapshot moves to QA) and we can validate this statement

DimStar77 commented 11 months ago

PR not needed - docker in fact recommends docker-buildx - so the pure presence of docker-buildx in ring1 makes it be present on the DVD and there is a reason for the package to be in ring1