search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

Draft: check_tags_in_request: search on the linked Factory project as well #3016

Closed g7 closed 10 months ago

g7 commented 10 months ago

The IBS instance embeds the whole project space of build.opensuse.org under openSUSE.org:.

This change allows for the changelog checker to search there as well, thus fixing checkTagNotRequired() when running inside the IBS.

g7 commented 10 months ago

Drafting, checking the failing tests

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: -6.64% :warning:

Comparison is base (fe4936c) 28.48% compared to head (97a461e) 21.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3016 +/- ## ========================================== - Coverage 28.48% 21.84% -6.64% ========================================== Files 85 85 Lines 14717 14717 ========================================== - Hits 4192 3215 -977 - Misses 10525 11502 +977 ``` | [Files Changed](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/3016?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE) | Coverage Δ | | |---|---|---| | [check\_tags\_in\_requests.py](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/3016?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE#diff-Y2hlY2tfdGFnc19pbl9yZXF1ZXN0cy5weQ==) | `0.00% <0.00%> (-54.98%)` | :arrow_down: | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/openSUSE/openSUSE-release-tools/pull/3016/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openSUSE)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilxam commented 10 months ago
  1. I hope you read https://github.com/openSUSE/openSUSE-release-tools/blob/master/check_tags_in_requests.py#L16 already, although I'm not sure how many place in the SLE development process still use this tool
  2. there is no openSUSE.org namespace on OBS, if it was hardcoded and without exception check then someone run this bot on OBS will just crashing, perhaps maintenance team still use this script on OBS, I'm not sure either
  3. there is --factory param to replace the default Factory project, ReviewBot will have it at least, if TagChecker needs a specific Factory project then it can resuse it everywhere else in the check_tags_in_request.py
  4. I don't get why do you need to check two Factory project, we don't have openSUSE:Factory project on IBS but an inherited openSUSE.org:openSUSE:Factory; vice versa, there is no openSUSE.org: namespace on OBS but a openSUSE:Factory exists.. even if you worked out the testdata and have had a passed tests, but it doesn't matches the reality
g7 commented 10 months ago

Hi, thanks for the review:

Yes, I think the only user of that would be check_tags_in_requests.py, missing projects are already handled gracefully.

But as for 3) indeed it works as well, got swayed by running it manually to debug another thing in the check_tags_in_request bot (totally overlooking --factory), looking at the gocd pipeline it already works as it should, so this is indeed useless :upside_down_face:

Thanks again and sorry for the noise!