search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
57 stars 91 forks source link

gocd: alp-stagings: Re enable Update.000products step for all stagings. #3028

Closed gleidi-suse closed 4 days ago

gleidi-suse commented 8 months ago

The step is actually required for openQA tests.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2891f13) 28.46% compared to head (2de218d) 28.46%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3028 +/- ## ======================================= Coverage 28.46% 28.46% ======================================= Files 85 85 Lines 14722 14722 ======================================= Hits 4191 4191 Misses 10531 10531 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilxam commented 8 months ago

when https://github.com/openSUSE/openSUSE-release-tools/pull/3024 has merged I'm guessing you may need to re-enable update-000product again unless you want to do a packagelist calculation for each staging per the changes are in the each staging, IOW manual patch 000product per the changes, it's not a terrible thing though if you know what needs add to packagelist and what needs to be drop off from the list.

I don't know what happens in ALP staging but I suppose ALP staging is at a broken state already(except of H), if the default pattern in groups.yml can not be fulfilled then pkglistgen would not give a right list still, but post the wrong bits instead, like add ''FOO is uninstallable: nothing provides BAR'' to packagelist, something like that, or pkglistgen just not to update 000product. In fact, if your staging is broken already, you should really fix your staging first: check-in the fix asap, or revert to a working version, make sure the requiring packages are installable. yes, you can workaround groups.yml to get a working packagelist by not adding broken package to packagelist, however you may get a non-working image, and lots of openqa failings. In short, you should fix your staging first :-)

gyr commented 8 months ago

I'm converting this to draft to avoid it be merge by mistake

dirkmueller commented 4 days ago

@gyr still needed? can be closed?

gyr commented 4 days ago

@gyr still needed? can be closed?

No, closing it.