SLSA support - Githubissues

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE

GNU General Public License v2.0

57 stars 91 forks source link

SLSA support #3058

Closed gyr closed 4 months ago

gyr commented 4 months ago

Due to SLSA constrains pkglistgen.py cannot run on botmaster using gocd, as it must run on a separate and isolated server the following changes were added:

create scripts that run pkgelistgen.py emulating the gocd pipelines (RelPkg and Update.000product)
create systemd services to execute the scripts for multiple SLSA project
add log support
create a rpm package that will be used to deploy it on SLSA server

codecov-commenter commented 4 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (54075b0) 28.31% compared to head (d380b44) 25.37%.

Files	Patch %	Lines
pkglistgen/tool.py	0.00%	4 Missing :warning:
pkglistgen/cli.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3058 +/- ## ========================================== - Coverage 28.31% 25.37% -2.95% ========================================== Files 86 86 Lines 14799 14803 +4 ========================================== - Hits 4191 3756 -435 - Misses 10608 11047 +439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilxam commented 4 months ago

the test is failed.

gyr commented 4 months ago

the test is failed.

Fixed, excluded the 2 SLSA scripts from the test as they don't have help flag because they are intended to be executed only by systemd services.

gyr commented 4 months ago

I'm fine with the change. But we might need to wait #3062 I assuming that, otherwise the packaging test can not be succesful if I understand that right...

All checks passed now, package built even with #3062 not being merged.

DimStar77 commented 3 months ago

somebody forgot about RPM 4.19:

can't install openSUSE-release-tools-slsa-build-service-20240315.b086253-1.1.noarch:
nothing provides group(osrt-slsa) needed by openSUSE-release-tools-slsa-build-service-20240315.b086253.noarch
nothing provides user(osrt-slsa) needed by openSUSE-release-tools-slsa-build-service-20240315.b086253.noarch

either the user is generated properly using sysusers.d or it is at least advertised in the pkg meta https://en.opensuse.org/openSUSE:Packaging_guidelines#Users_and_Groups