search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
57 stars 90 forks source link

pkglistgen.py: Run product-composer iif there's a *.productcompose.in file and a 000productcompose directory. #3079

Closed gleidi-suse closed 1 month ago

gleidi-suse commented 1 month ago

Previously pkglistgen.py assumed that a project either used product-builder or the new product-composer, by exiting unrecoverably when a *.productcompose.in file was found but the relative 000productcompose directory was absent.

This is not the case for SL Micro as the shared SLFO codebase is still an hybrid OBS/git project and hence its stagings are not git based and can't use product composer.

This patch was tested for the SUSE:ALP:Source:Standard:1.0:Staging:A and SUSE:ALP:Products:Marble:6.0 projects (together with https://github.com/openSUSE/openSUSE-release-tools/pull/3078). Instead of raising an exception when the 000productcompose directory is not found it makes a log stating that product-composer will be skipped.

Vogtinator commented 1 month ago

This is not the case for SL Micro as the shared SLFO codebase is still an hybrid OBS/git project and hence its stagings are not git based and can't use product composer.

Why not? 000productcompose should work without git.

gleidi-suse commented 1 month ago

Why not? 000productcompose should work without git.

I believe the problem is with the SR stagings flow and the git backend. I was told it is still not implemented so SRs for SUSE:SLFO:Main are still done with osc and not git

Vogtinator commented 1 month ago

Why not? 000productcompose should work without git.

I believe the problem is with the SR stagings flow and the git backend. I was told it is still not implemented so SRs for SUSE:SLFO:Main are still done with osc and not git

Do the stagings have an scmsync url set on a prj level or for 000productcompose? If not, it should work fine.