openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
61 stars 97 forks source link

Support msgid domain override #3084

Closed tacerus closed 3 months ago

tacerus commented 4 months ago

The domain set by email.utils defaults to the one from the calling system. Systems having theirs set to "localhost" risk increased spam scoring. Allow the override of the domain on such systems using a configuration option.

Note: please test this yourself, I could not find a fitting YAML configuration file in this repository and don't know where you are executing this script from. I only confirmed the domain option to work by copying the message and SMTP lines into a short sample Python script, which executed and sent the mail as expected.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.02%. Comparing base (b854784) to head (52e848d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3084 +/- ## ======================================= Coverage 28.02% 28.02% ======================================= Files 86 86 Lines 14981 14981 ======================================= Hits 4199 4199 Misses 10782 10782 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Vogtinator commented 4 months ago

According to the documentation, this uses the system's hostname by default. Apparently that's already broken.

Vogtinator commented 4 months ago

According to the documentation, this uses the system's hostname by default. Apparently that's already broken.

@sysrich can you check what's set in the used botmaster agent and maybe adjust it?

Vogtinator commented 4 months ago

According to the documentation, this uses the system's hostname by default. Apparently that's already broken.

@sysrich can you check what's set in the used botmaster agent and maybe adjust it?

@sysrich ping ^

FWICT this should basically work OOTB, even with the default docker and podman container settings which just use an autogenerated hostname.

DimStar77 commented 3 months ago

https://github.com/openSUSE/openSUSE-release-tools/pull/3087 was merged and helped to get Richard's mails through the spam filter