search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
57 stars 90 forks source link

gocd: slfo-stagings: wait for product to be built before enabling images #3104

Closed g7 closed 3 weeks ago

g7 commented 3 weeks ago

During image testing, the artifacts built inside the 'product' repository are used. Let's ensure that the repository is fully built before attempting to enable images.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.00%. Comparing base (fe74cce) to head (f258efa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3104 +/- ## ======================================= Coverage 28.00% 28.00% ======================================= Files 86 86 Lines 14993 14993 ======================================= Hits 4199 4199 Misses 10794 10794 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DimStar77 commented 2 weeks ago

This is apparently the one that caused the SLFO pipelines to enter endless loupes.

BotMaster should be either used event-based or time-based, but do not run 'endless' jobs waiting 'forever'

The number of agents is limited and any job running 'forever' (longer than needed) takes agents from the pool away

g7 commented 2 weeks ago

argh, sorry about that.

It is a bug that a SLFO staging doesn't have any 'product' repository, but until #3103 is in and everyone runs with the up-to-date staging plugin freezing might drop the repository and cause this.

But it is a good point indeed - I will add a check for the repo existence, and perhaps a timeout for now. And I will think about some smarter way to do the same without waiting.